BigW Consortium Gitlab

  1. 09 Jun, 2016 3 commits
    • Add #18019 to the CHANGELOG. · 19b91e74
      Timothy Andrew authored
    • Hook up the updated `WikiLinkFilter` to the wiki controllers. · e6b1d166
      Timothy Andrew authored
      - Need to pass in a `page_slug` to the filter, so it can rewrite based
        on the current page (all links are rewritten to the level of the app root).
      - The earlier `markdown_preview` endpoint was at the level of the wiki.
        We need to know the current page (for rewriting, as above), so this
        commit moves the endpoint to the level of a wiki page.
      - Fix all tests
    • Implement the correct linking behaviour in `WikiLinkFilter`. · 8e71c19a
      Timothy Andrew authored
      Original Comments
      =================
      
      - Linking behaves as per rules documented here:
        https://gitlab.com/gitlab-org/gitlab-ce/blob/16568-document-wiki-linking-behavior/doc/markdown/wiki.md
      - All links (to other wiki pages) are rewritten to be at the level of
        the app root. We can't use links relative to the current
        page ('./foo', 'foo', '../foo'), because they won't work in the
        markdown preview, where the current page is suffixed with `/edit`
      - Move existing `WikiLinkFilter` specs to `WikiPipeline` spec. It makes
        sense to run these tests on the combined output of the pipeline,
        rather than a single filter, since we can catch issues with
        conflicting filters.
      - Add more tests to cover the new linking
      
      @rymai's Review
      ===============
      
      - Classes nested under `WikiLinkFilter` should declare `WikiLinkFilter`'s
        inherit, so nothing changes if the nested class is loaded first.
      - Add a blank line after a guard clause
      - Use keyword arguments for the `Rewriter` constructor
      - Invert a condition - use `if` instead of `unless`
      - Inline a `let` in `WikiPipeline` spec - it was only used in a single place
      - Change out of date spec names
      - Add a comment for every rewrite rule in `Rewriter`
  2. 02 Jun, 2016 9 commits
  3. 01 Jun, 2016 28 commits
    • Merge branch 'downcase-registry-repository' into 'master' · 3b53016f
      Stan Hu authored
      Use downcased path to container repository as this is expected path by Docker
      
      ## What does this MR do?
      
      Docker Engine requires path to be lowercase. This makes all container registry paths to be show and used downcased instead of mixed case.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17959
      
      
      See merge request !4420
    • Merge branch '17187-hover-row' into 'master' · 07fb3815
      Jacob Schatz authored
      Implement new row hover style
      
      ## What does this MR do?
      Implement new row hover style
      
      ## What are the relevant issue numbers?
      Closes #17187 
      
      ## Screenshots (if relevant)
      ![Screen_Shot_2016-06-01_at_1.40.04_PM](/uploads/62db01f405db50531fb648e46dc9598a/Screen_Shot_2016-06-01_at_1.40.04_PM.png)   
      
      cc @dzaporozhets 
      
      See merge request !4422
    • Implement new row hover style · d7c76d09
      Annabel Dunstone authored
    • Merge branch '17676-merge-request-widget-alignment' into 'master' · 0f96a6c2
      Jacob Schatz authored
      MR widget mobile styling
      
      ## What does this MR do?
      
      Corrects MR widget styling for mobile viewing.
      
      ## Are there points in the code the reviewer needs to double check?
      
      I have tested all MR states.
      
      ## Why was this MR needed?
      
      UX.
      
      ## What are the relevant issue numbers?
      
      Closes #17676.
      
      ## Screenshots (if relevant)
      
      ![Screen_Shot_2016-05-31_at_20.04.02](/uploads/b1bc67b1015b2e771ae1b1364b225618/Screen_Shot_2016-05-31_at_20.04.02.png)![Screen_Shot_2016-05-31_at_20.03.50](/uploads/86a552c0d27d6f53cdf1b94631b26449/Screen_Shot_2016-05-31_at_20.03.50.png)![Screen_Shot_2016-05-31_at_20.03.34](/uploads/a5b9e7b634e974095922df9194d493b5/Screen_Shot_2016-05-31_at_20.03.34.png)![Screen_Shot_2016-05-31_at_20.01.35](/uploads/2fc5d49e3c1f2ff2cb324e9527179066/Screen_Shot_2016-05-31_at_20.01.35.png)![Screen_Shot_2016-05-31_at_20.00.25](/uploads/23af913891ff941dc5231872b3c6f177/Screen_Shot_2016-05-31_at_20.00.25.png)![Screen_Shot_2016-05-31_at_19.59.53](/uploads/8abb72609409ba7ca02ad6b35787c15c/Screen_Shot_2016-05-31_at_19.59.53.png)![Screen_Shot_2016-05-31_at_19.58.31](/uploads/fabf1c6c135f5e736614e568fc4cfb53/Screen_Shot_2016-05-31_at_19.58.31.png)![Screen_Shot_2016-05-31_at_19.58.51](/uploads/967a578a34cb3a9dd3723c2f22ce89c4/Screen_Shot_2016-05-31_at_19.58.51.png)![Screen_Shot_2016-05-31_at_23.33.19](/uploads/841af7a90bb3fc3c74a2e51b64fc444f/Screen_Shot_2016-05-31_at_23.33.19.png)![Screen_Shot_2016-05-31_at_23.33.23](/uploads/183fb8407c271d9aa3fefea5d8201238/Screen_Shot_2016-05-31_at_23.33.23.png)
      
      See merge request !4386
    • Merge branch 'fix-note-validation-failure' into 'master' · e9bb895b
      Stan Hu authored
      Fix note validation spec failure
      
      Fix failing build due to project of note not matching issue project.
      
      See merge request !4415
    • Merge branch 'add-edge-support' into 'master' · 5a377d20
      Jacob Schatz authored
      Add Edge to supported browsers list.
      
      Add Microsoft's Edge browser to the list of supported browsers. We support the latest stable version.
      
      See merge request !4416
    • Merge branch 'dont-advertise-ci-skip' into 'master' · 93e2761c
      Robert Speicher authored
      Don't advertise the use of "ci skip" in the CONTRIBUTING guide
      
      [ci skip]
      
      See merge request !4406
    • Merge branch 'style/enable-semicolon-rubocop-cop' into 'master' · 3d3c9c75
      Robert Speicher authored
      Enable Style/Semicolon rubocop style cop
      
      Don't use semicolons to terminate expressions.
      
      See #17478.
      
      See merge request !4351
    • Merge branch 'rubocop/enable-style-for-cop' into 'master' · 164fc34e
      Robert Speicher authored
      Enable Style/For rubocop cop
      
      > Do not use `for`, unless you know exactly why. Most of the time iterators should be used instead. `for` is implemented in terms of `each` (so you're adding a level of indirection), but with a twist - `for` doesn't introduce a new scope (unlike `each`) and variables defined in its block will be visible outside it.
      
      See #17478
      
      See merge request !4397
    • Fix note validation spec failures · 30aa6420
      Stan Hu authored
    • Merge branch 'dz-one-ci-cd-tab' into 'master' · 4621531a
      Dmitriy Zaporozhets authored
      Merge Builds and Pipelines tab into one
      
      Based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4053#note_12064642. Main idea is to keep all CI-related pages under one tab. So we can keep top navigation clean. 
      
      First I tried `CI/CD` naming but it looked weird so I just used Pipelines as tab name. I did not change project settings naming. 
      
      cc @ayufan @markpundsack @jschatz1 
      
      See merge request !4340
    • Merge branch 'separate-banzai-references' into 'master' · 2d084dd8
      Douwe Maan authored
      Separate reference gathering from rendering
      
      This is a required step to allow batch processing when gathering references. This in turn would allow grabbing (for example) all mentioned users of an issue/merge request using a single query.
      
      cc @rspeicher @DouweM 
      
      See merge request !3969
    • Refactor Participable · 580d2501
      Yorick Peterse authored
      There are several changes to this module:
      
      1. The use of an explicit stack in Participable#participants
      2. Proc behaviour has been changed
      3. Batch permissions checking
      
      == Explicit Stack
      
      Participable#participants no longer uses recursion to process "self" and
      all child objects, instead it uses an Array and processes objects in
      breadth-first order. This allows us to for example create a single
      Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
      a ReferenceExtractor removes the need for running potentially many SQL
      queries every time a Proc is called on a new object.
      
      == Proc Behaviour Changed
      
      Previously a Proc in Participable was expected to return an Array of
      User instances. This has been changed and instead it's now expected that
      a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
      value of the Proc is ignored.
      
      == Permissions Checking
      
      The method Participable#participants uses
      Ability.users_that_can_read_project to check if the returned users have
      access to the project of "self" _without_ running multiple SQL queries
      for every user.
    • Merge branch 'fix-cancelable-retryable' into 'master' · ef6fe42e
      Douwe Maan authored
      Fix cancelability and retriablity of pipeline with generic statuses
      
      Currently it's not possible to cancel or retry generic status since this is external thing to GitLab.
      
      This fixes shown actions of pipelines containing only these actions.
      
      
      See merge request !4380
    • Merge branch 'fix/error-500-in-pipeline-when-fork' into 'master' · 4581e71c
      Rémy Coutable authored
      Use project that belongs to pipeline in view
      
      ## What does this MR do?
      
      This MR makes project in pipelines view match the one that pipeline has been created for.
      
      Closes #17943 
      
      See merge request !4376
    • Don't advertise the use of "ci skip" in the CONTRIBUTING guide · ea80259b
      Rémy Coutable authored
      Now that we autoscale runner, we don't need to optimize for their usage
      anymore. Abusing of "ci skip", for instance for view changes can lead to
      broken specs, so let's just not use it!
      Signed-off-by: 's avatarRémy Coutable <remy@rymai.me>
    • Fix rubocop offenses · 57992f3d
      Kamil Trzcinski authored
    • Merge branch 'emails-on-push-use-sidekiq-mailers' into 'master' · 9d88a3a1
      Douwe Maan authored
      Make EmailsOnPushWorker use Sidekiq mailers queue
      
      A customer was having issues with EmailsOnPushWorker clogging the Sidekiq queues and merge requests not being handled quickly. While researching whether it would possible to spin up a separate Sidekiq task just to handle merge requests and other key functions, I found that this worker was using the default Sidekiq queue. Moving to the `mailers` queue makes it possible to de-prioritize this worker and give more weight to the others.
      
      See merge request !4390
    • Merge branch 'prefer-to_reference' into 'master' · 173d83ca
      Douwe Maan authored
      Use `Snippet#to_reference` directly
      
      ## What does this MR do?
      
      Instead of hard coding snippet reference, we could just use the existing method for that.
      
      ## Why was this MR needed?
      
      To address https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4338#note_12166325 from @DouweM
      
      /cc @jschatz1 
      
      See merge request !4379
    • Merge branch 'rs-remember-me-2fa' into 'master' · 3416bc53
      Douwe Maan authored
      Pass the "Remember me" value to the 2FA token form
      
      Prior, if a user had 2FA enabled and checked the "Remember me" field,
      the setting was ignored because the OTP input was on a new form and the
      value was never passed.
      
      Closes #18000
      
      See merge request !4369
    • Merge branch 'fix-404-labels-in-todos' into 'master' · c0f19cc9
      Douwe Maan authored
      Fix 404 page when viewing TODOs that contain milestones or labels in different projects
      
      A user viewing the TODOs page will see a 404 if there are mentioned milestones or labels in multiple different projects. This is likely a caching bug and only occurs
      when Markdown rendering occurs across multiple projects, which is why it's so tricky to reproduce. This is what I think is happening:
          
      1. LabelReferenceFilter#references_in encounters label ~X for ProjectA and finds the label in the DB as id = 1.
      2. LabelReferenceFilter.references_in yields [1, 'X', nil, ...]
      3. Since project_ref is nil, AbstractReferenceFilter#project_from_ref_cache caches nil => ProjectA.
      4. LabelReferenceFilter#references_in encounters label ~Y for ProjectB and finds the label in the DB as id = 2.
      5. LabelReferenceFilter.references_in yields [2, 'Y', nil, ...]
      6. AbstractReferenceFilter#project_from_ref_cache lookups nil and returns ProjectA. It was supposed to be ProjectB.
      7. A is the wrong project, so the label lookup fails.
         
      This MR expands the `project_ref` to the right value as soon as we have it to avoid this caching bug.
          
      Closes #17898
      
      
      See merge request !4312