Change trigger('click') -> click for Chrome

spec/features/dashboard/issues_spec.rb

@@ -80,7 +80,7 @@ RSpec.describe 'Dashboard Issues' do
     end
 
     it 'shows the new issue page', :js do
-      find('.new-project-item-select-button').trigger('click')
+      find('.new-project-item-select-button').click
       wait_for_requests
       find('.select2-results li').click
 

spec/features/dashboard/todos/todos_spec.rb

@@ -252,7 +252,7 @@ feature 'Dashboard Todos' do
     describe 'mark all as done', js: true do
       before do
         visit dashboard_todos_path
-        find('.js-todos-mark-all').trigger('click')
+        find('.js-todos-mark-all').click
       end
 
       it 'shows "All done" message!' do
@@ -309,9 +309,9 @@ feature 'Dashboard Todos' do
       end
 
       def mark_all_and_undo
-        find('.js-todos-mark-all').trigger('click')
+        find('.js-todos-mark-all').click
         wait_for_requests
-        find('.js-todos-undo-all').trigger('click')
+        find('.js-todos-undo-all').click
         wait_for_requests
       end
     end

spec/features/issues/gfm_autocomplete_spec.rb

@@ -19,7 +19,7 @@ feature 'GFM autocomplete', js: true do
 
     find('#issue-description').native.send_keys("@#{user.name[0...3]}")
 
-    find('.atwho-view .cur').trigger('click')
+    find('.atwho-view .cur').click
 
     click_button 'Save changes'
 

spec/features/profiles/user_visits_notifications_tab_spec.rb

@@ -13,7 +13,7 @@ feature 'User visits the notifications tab', js: true do
   it 'changes the project notifications setting' do
     expect(page).to have_content('Notifications')
 
-    first('#notifications-button').trigger('click')
+    first('#notifications-button').click
     click_link('On mention')
 
     expect(page).to have_content('On mention')

spec/features/projects/environments/environments_spec.rb

@@ -151,7 +151,7 @@ feature 'Environments page', :js do
           find('.js-dropdown-play-icon-container').click
           expect(page).to have_content(action.name.humanize)
 
-          expect { find('.js-manual-action-link').trigger('click') }
+          expect { find('.js-manual-action-link').click }
             .not_to change { Ci::Pipeline.count }
         end
 

spec/features/projects/wiki/user_creates_wiki_page_spec.rb

@@ -15,7 +15,7 @@ feature 'Projects > Wiki > User creates wiki page', :js do
 
     context 'when wiki is empty' do
       before do
-        find('.shortcuts-wiki').trigger('click')
+        find('.shortcuts-wiki').click
       end
 
       scenario 'commit message field has value "Create home"' do
@@ -70,7 +70,7 @@ feature 'Projects > Wiki > User creates wiki page', :js do
     context 'when wiki is not empty' do
       before do
         WikiPages::CreateService.new(project, user, title: 'home', content: 'Home page').execute
-        find('.shortcuts-wiki').trigger('click')
+        find('.shortcuts-wiki').click
       end
 
       context 'via the "new wiki page" page' do
@@ -161,7 +161,7 @@ feature 'Projects > Wiki > User creates wiki page', :js do
 
     context 'when wiki is empty' do
       before do
-        find('.shortcuts-wiki').trigger('click')
+        find('.shortcuts-wiki').click
       end
 
       scenario 'commit message field has value "Create home"' do
@@ -183,7 +183,7 @@ feature 'Projects > Wiki > User creates wiki page', :js do
     context 'when wiki is not empty' do
       before do
         WikiPages::CreateService.new(project, user, title: 'home', content: 'Home page').execute
-        find('.shortcuts-wiki').trigger('click')
+        find('.shortcuts-wiki').click
       end
 
       scenario 'via the "new wiki page" page' do

spec/features/tags/master_creates_tag_spec.rb

@@ -63,7 +63,7 @@ feature 'Master creates tag' do
         expect(ref_input.value).to eq 'master'
         expect(find('.dropdown-toggle-text')).to have_content 'master'
 
-        find('.js-branch-select').trigger('click')
+        find('.js-branch-select').click
 
         expect(find('.dropdown-menu')).to have_content 'empty-branch'
       end

spec/javascripts/integrations/integration_settings_form_spec.js

@@ -168,7 +168,7 @@ describe('IntegrationSettingsForm', () => {
       expect($flashAction).toBeDefined();
 
       spyOn(integrationSettingsForm.$form, 'submit');
-      $flashAction.trigger('click');
+      $flashAction.click;
       expect(integrationSettingsForm.$form.submit).toHaveBeenCalled();
     });
 

spec/javascripts/issue_spec.js

@@ -128,7 +128,7 @@ describe('Issue', function() {
       });
 
       it(`${action}s the issue`, function() {
-        this.$triggeredButton.trigger('click');
+        this.$triggeredButton.click;
         this.issueStateDeferred.resolve({
           id: 34
         });
@@ -143,7 +143,7 @@ describe('Issue', function() {
       });
 
       it(`fails to ${action} the issue if saved:false`, function() {
-        this.$triggeredButton.trigger('click');
+        this.$triggeredButton.click;
         this.issueStateDeferred.resolve({
           saved: false
         });
@@ -159,7 +159,7 @@ describe('Issue', function() {
       });
 
       it(`fails to ${action} the issue if HTTP error occurs`, function() {
-        this.$triggeredButton.trigger('click');
+        this.$triggeredButton.click;
         this.issueStateDeferred.reject();
         this.canCreateBranchDeferred.resolve({
           can_create_branch: isIssueInitiallyOpen
@@ -173,7 +173,7 @@ describe('Issue', function() {
       });
 
       it('disables the new branch button if Ajax call fails', function() {
-        this.$triggeredButton.trigger('click');
+        this.$triggeredButton.click;
         this.issueStateDeferred.reject();
         this.canCreateBranchDeferred.reject();
 
@@ -184,7 +184,7 @@ describe('Issue', function() {
         Issue.$btnNewBranch = $();
         this.canCreateBranchDeferred = null;
 
-        this.$triggeredButton.trigger('click');
+        this.$triggeredButton.click;
         this.issueStateDeferred.reject();
       });
     });

spec/javascripts/merge_request_notes_spec.js

@@ -84,7 +84,7 @@ describe('Merge request notes', () => {
 
         spyOnEvent('.note:last .js-note-edit', 'click');
 
-        $('.js-discussion-reply-button').trigger('click');
+        $('.js-discussion-reply-button').click;
 
         setTimeout(() => {
           $('.js-note-text').trigger(upArrowEvent);

spec/javascripts/pipeline_schedules/setup_pipeline_variable_list_spec.js

@@ -92,7 +92,7 @@ describe('Pipeline Variable List', () => {
     });
 
     it('should remove the row when clicking the remove button', () => {
-      $markup.find('.js-row-remove-button').trigger('click');
+      $markup.find('.js-row-remove-button').click;
 
       expect($markup.find('.js-row').length).toBe(0);
     });

spec/javascripts/u2f/authenticate_spec.js

@@ -44,7 +44,7 @@ import './mock_u2f_device';
       it("displays an error message", function() {
         var errorMessage, setupButton;
         setupButton = this.container.find("#js-login-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToAuthenticateRequest({
           errorCode: "error!"
         });
@@ -54,14 +54,14 @@ import './mock_u2f_device';
       return it("allows retrying authentication after an error", function() {
         var retryButton, setupButton;
         setupButton = this.container.find("#js-login-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToAuthenticateRequest({
           errorCode: "error!"
         });
         retryButton = this.container.find("#js-u2f-try-again");
-        retryButton.trigger('click');
+        retryButton.click;
         setupButton = this.container.find("#js-login-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToAuthenticateRequest({
           deviceData: "this is data from the device"
         });

spec/javascripts/u2f/register_spec.js

@@ -23,7 +23,7 @@ import './mock_u2f_device';
       var deviceResponse, inProgressMessage, registeredMessage, setupButton;
       setupButton = this.container.find("#js-setup-u2f-device");
       expect(setupButton.text()).toBe('Setup new U2F device');
-      setupButton.trigger('click');
+      setupButton.click;
       inProgressMessage = this.container.children("p");
       expect(inProgressMessage.text()).toContain("Trying to communicate with your device");
       this.u2fDevice.respondToRegisterRequest({
@@ -38,7 +38,7 @@ import './mock_u2f_device';
       it("doesn't allow the same device to be registered twice (for the same user", function() {
         var errorMessage, setupButton;
         setupButton = this.container.find("#js-setup-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToRegisterRequest({
           errorCode: 4
         });
@@ -48,7 +48,7 @@ import './mock_u2f_device';
       it("displays an error message for other errors", function() {
         var errorMessage, setupButton;
         setupButton = this.container.find("#js-setup-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToRegisterRequest({
           errorCode: "error!"
         });
@@ -58,14 +58,14 @@ import './mock_u2f_device';
       return it("allows retrying registration after an error", function() {
         var registeredMessage, retryButton, setupButton;
         setupButton = this.container.find("#js-setup-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToRegisterRequest({
           errorCode: "error!"
         });
         retryButton = this.container.find("#U2FTryAgain");
-        retryButton.trigger('click');
+        retryButton.click;
         setupButton = this.container.find("#js-setup-u2f-device");
-        setupButton.trigger('click');
+        setupButton.click;
         this.u2fDevice.respondToRegisterRequest({
           deviceData: "this is data from the device"
         });