Fix Issue board when using Ruby 2.4

In Ruby 2.4, Hash#compact exists and returns a Hash, while in Ruby 2.3, Hash#compact is implemented by Rails and returns a new `ActionController::Parameters` instance in this case. Also, `ActionController::Parameters#compact` is deprecated in Rails 5.1 so we're using `reject { |_, value| value.nil? }` instead. Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix Issue board when using Ruby 2.4
f67c7a4d · Rémy Coutable · e753444c · f67c7a4d · f67c7a4d
Commit f67c7a4d authored Aug 01, 2017 by Rémy Coutable
Showing with 6 additions and 1 deletion

issues_controller.rb app/controllers/projects/boards/issues_controller.rb +2 -1

35769-fix-ruby-2-4-compatibility.yml changelogs/unreleased/35769-fix-ruby-2-4-compatibility.yml +4 -0

No files found.
--- a/app/controllers/projects/boards/issues_controller.rb
+++ b/app/controllers/projects/boards/issues_controller.rb
@@ -66,7 +66,8 @@ module Projects
      end

      def filter_params
-        params.merge(board_id: params[:board_id], id: params[:list_id]).compact
+        params.merge(board_id: params[:board_id], id: params[:list_id])
+          .reject { |_, value| value.nil? }
      end

      def move_params

--- a/changelogs/unreleased/35769-fix-ruby-2-4-compatibility.yml
+++ b/changelogs/unreleased/35769-fix-ruby-2-4-compatibility.yml
+---
+title: Fix Issue board when using Ruby 2.4
+merge_request: 13220
+author: