Don't wrap arrays twice: `children` are already wrapped in an array

We do the wrapping in an array in represent_hierarchy for children.

Don't wrap arrays twice: `children` are already wrapped in an array
ee2744c6 · Bob Van Landuyt · e13753fc · ee2744c6
Commit ee2744c6 authored Sep 22, 2017 by Bob Van Landuyt
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

group_child_serializer.rb app/serializers/group_child_serializer.rb +2 -2

No files found.
--- a/app/serializers/group_child_serializer.rb
+++ b/app/serializers/group_child_serializer.rb
@@ -27,8 +27,8 @@ class GroupChildSerializer < BaseSerializer
    if children.is_a?(GroupDescendant)
      represent_hierarchy(children.hierarchy(hierarchy_root), opts).first
    else
-      hierarchies = Array.wrap(GroupDescendant.merge_hierarchies(children, hierarchy_root))
+      hierarchies = GroupDescendant.merge_hierarchies(children, hierarchy_root)
-      hierarchies.map { |hierarchy| represent_hierarchy(hierarchy, opts) }.flatten
+      represent_hierarchy(hierarchies, opts)
    end
  end