Merge branch 'add-cookie-expirations-to-callouts' into 'master'

Add expirations to CA and user callouts Closes #30267 See merge request !10568

Merge branch 'add-cookie-expirations-to-callouts' into 'master'
ec5ba730 · Phil Hughes · e04aef5c · 0636320e · ec5ba730 · ec5ba730
Commit ec5ba730 authored Apr 14, 2017 by Phil Hughes
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

cycle_analytics_bundle.js ...ets/javascripts/cycle_analytics/cycle_analytics_bundle.js +1 -1

user_callout.js app/assets/javascripts/user_callout.js +1 -1

No files found.
--- a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
+++ b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
@@ -125,7 +125,7 @@ $(() => {
      },
      dismissOverviewDialog() {
        this.isOverviewDialogDismissed = true;
-        Cookies.set(OVERVIEW_DIALOG_COOKIE, '1');
+        Cookies.set(OVERVIEW_DIALOG_COOKIE, '1', { expires: 365 });
      },
    },
  });

--- a/app/assets/javascripts/user_callout.js
+++ b/app/assets/javascripts/user_callout.js
@@ -18,7 +18,7 @@ export default class UserCallout {
  dismissCallout(e) {
    const $currentTarget = $(e.currentTarget);

-    Cookies.set(USER_CALLOUT_COOKIE, 'true');
+    Cookies.set(USER_CALLOUT_COOKIE, 'true', { expires: 365 });

    if ($currentTarget.hasClass('close')) {
      this.userCalloutBody.remove();