Make `ChangePersonalAccessTokensDefaultBackToEmptyArray` a "post" migration.

If we leave this as a regular migration, we could have the following flow: 1. Application knows nothing about scopes. 2. First migration runs, all existing personal access tokens have `api` scope 3. Application still knows nothing about scopes. 4. Second migration runs, all tokens created after this point have no scope 5. Application still knows nothing about scopes. 6. Tokens created at this time _should have the API scope, but instead have no scope_ 7. Application code is reloaded, application knows about scopes 8. Tokens created after this point only have no scope if the user deliberately chooses to have no scopes. Point #6 is the problem here. To avoid this, we move the second migration to a "post" migration, which runs after the application code is deployed/reloaded.

Make `ChangePersonalAccessTokensDefaultBackToEmptyArray` a "post" migration.
eb434b15 · Timothy Andrew · 5becbe24 · eb434b15
Commit eb434b15 authored Dec 16, 2016 by Timothy Andrew
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

20160824121037_change_personal_access_tokens_default_back_to_empty_array.rb ...nge_personal_access_tokens_default_back_to_empty_array.rb +4 -2

No files found.
--- a/db/migrate/20160824121037_change_personal_access_tokens_default_back_to_empty_array.rb
+++ b/db/migrate/20160824121037_change_personal_access_tokens_default_back_to_empty_array.rb
 # The default needs to be `[]`, but all existing access tokens need to have `scopes` set to `['api']`.
-# It's easier to achieve this by adding the column with the `['api']` default, and then changing the default to
-# `[]`.
+# It's easier to achieve this by adding the column with the `['api']` default (regular migration), and
+# then changing the default to `[]` (in this post-migration).
+#
+# Details: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5951#note_19721973

 class ChangePersonalAccessTokensDefaultBackToEmptyArray < ActiveRecord::Migration
  include Gitlab::Database::MigrationHelpers