BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
eaad236b
Unverified
Commit
eaad236b
authored
Feb 05, 2016
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove project-issuable-filter from admin builds page :)
Signed-off-by:
Dmitriy Zaporozhets
<
dmitriy.zaporozhets@gmail.com
>
parent
92586360
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
28 deletions
+15
-28
issuable.scss
app/assets/stylesheets/pages/issuable.scss
+3
-15
index.html.haml
app/views/admin/builds/index.html.haml
+6
-7
admin_builds_spec.rb
spec/features/admin/admin_builds_spec.rb
+6
-6
No files found.
app/assets/stylesheets/pages/issuable.scss
View file @
eaad236b
...
...
@@ -29,17 +29,6 @@
}
}
.project-issuable-filter
{
.controls
{
float
:
right
;
margin-top
:
11px
;
}
.nav-links
{
text-align
:
left
;
}
}
.issuable-details
{
section
{
.issuable-discussion
{
...
...
@@ -72,7 +61,7 @@
@include
clearfix
;
padding
:
$gl-padding
0
;
border-bottom
:
1px
solid
$border-gray-light
;
// This prevents the mess when resizing the sidebar
// This prevents the mess when resizing the sidebar
// of elements repositioning themselves..
width
:
$gutter_inner_width
;
overflow-x
:
hidden
;
...
...
@@ -206,7 +195,7 @@
}
&
.right-sidebar-collapsed
{
.issuable-count
,
.issuable-count
,
.issuable-nav
,
.assignee
>
*,
.milestone
>
*,
...
...
@@ -243,4 +232,4 @@
display
:
none
;
}
}
}
\ No newline at end of file
}
app/views/admin/builds/index.html.haml
View file @
eaad236b
.project-issuable-filter
.controls
.pull-left.hidden-xs
-
if
@all_builds
.
running_or_pending
.
any?
=
link_to
'Cancel all'
,
cancel_all_admin_builds_path
,
data:
{
confirm:
'Are you sure?'
},
class:
'btn btn-danger'
,
method: :post
.top-area
%ul
.nav-links
%li
{
class:
(
'active'
if
@scope
.
nil?
)}
=
link_to
admin_builds_path
do
...
...
@@ -20,7 +15,11 @@
Finished
%span
.badge.js-running-count
=
number_with_delimiter
(
@all_builds
.
finished
.
count
(
:id
))
.gray-content-block
.nav-controls
-
if
@all_builds
.
running_or_pending
.
any?
=
link_to
'Cancel all'
,
cancel_all_admin_builds_path
,
data:
{
confirm:
'Are you sure?'
},
class:
'btn btn-danger'
,
method: :post
.gray-content-block.second-block
#{
(
@scope
||
'running'
).
capitalize
}
builds
%ul
.content-list
...
...
spec/features/admin/admin_builds_spec.rb
View file @
eaad236b
...
...
@@ -18,7 +18,7 @@ describe 'Admin Builds' do
visit
admin_builds_path
expect
(
page
).
to
have_selector
(
'.
project-issuable-filter
li.active'
,
text:
'All'
)
expect
(
page
).
to
have_selector
(
'.
nav-links
li.active'
,
text:
'All'
)
expect
(
page
.
all
(
'.build-link'
).
size
).
to
eq
(
4
)
expect
(
page
).
to
have_link
'Cancel all'
end
...
...
@@ -28,7 +28,7 @@ describe 'Admin Builds' do
it
'shows a message'
do
visit
admin_builds_path
expect
(
page
).
to
have_selector
(
'.
project-issuable-filter
li.active'
,
text:
'All'
)
expect
(
page
).
to
have_selector
(
'.
nav-links
li.active'
,
text:
'All'
)
expect
(
page
).
to
have_content
'No builds to show'
expect
(
page
).
not_to
have_link
'Cancel all'
end
...
...
@@ -44,7 +44,7 @@ describe 'Admin Builds' do
visit
admin_builds_path
(
scope: :running
)
expect
(
page
).
to
have_selector
(
'.
project-issuable-filter
li.active'
,
text:
'Running'
)
expect
(
page
).
to
have_selector
(
'.
nav-links
li.active'
,
text:
'Running'
)
expect
(
page
.
find
(
'.build-link'
)).
to
have_content
(
build1
.
id
)
expect
(
page
.
find
(
'.build-link'
)).
not_to
have_content
(
build2
.
id
)
expect
(
page
.
find
(
'.build-link'
)).
not_to
have_content
(
build3
.
id
)
...
...
@@ -58,7 +58,7 @@ describe 'Admin Builds' do
visit
admin_builds_path
(
scope: :running
)
expect
(
page
).
to
have_selector
(
'.
project-issuable-filter
li.active'
,
text:
'Running'
)
expect
(
page
).
to
have_selector
(
'.
nav-links
li.active'
,
text:
'Running'
)
expect
(
page
).
to
have_content
'No builds to show'
expect
(
page
).
not_to
have_link
'Cancel all'
end
...
...
@@ -74,7 +74,7 @@ describe 'Admin Builds' do
visit
admin_builds_path
(
scope: :finished
)
expect
(
page
).
to
have_selector
(
'.
project-issuable-filter
li.active'
,
text:
'Finished'
)
expect
(
page
).
to
have_selector
(
'.
nav-links
li.active'
,
text:
'Finished'
)
expect
(
page
.
find
(
'.build-link'
)).
not_to
have_content
(
build1
.
id
)
expect
(
page
.
find
(
'.build-link'
)).
not_to
have_content
(
build2
.
id
)
expect
(
page
.
find
(
'.build-link'
)).
to
have_content
(
build3
.
id
)
...
...
@@ -88,7 +88,7 @@ describe 'Admin Builds' do
visit
admin_builds_path
(
scope: :finished
)
expect
(
page
).
to
have_selector
(
'.
project-issuable-filter
li.active'
,
text:
'Finished'
)
expect
(
page
).
to
have_selector
(
'.
nav-links
li.active'
,
text:
'Finished'
)
expect
(
page
).
to
have_content
'No builds to show'
expect
(
page
).
to
have_link
'Cancel all'
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment