Still grant :download_code if guest could do that

Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7383#note_18518792

Still grant :download_code if guest could do that
e72e2f9b · Lin Jen-Shin · 0c532dbb · e72e2f9b
Commit e72e2f9b authored Nov 18, 2016 by Lin Jen-Shin
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

git_access.rb lib/gitlab/git_access.rb +3 -5

No files found.
--- a/lib/gitlab/git_access.rb
+++ b/lib/gitlab/git_access.rb
@@ -48,11 +48,9 @@ module Gitlab
        deploy_key.has_access_to?(project)
      elsif user
        user_download_access_check
-      elsif Guest.can?(:download_code, project)
+      end ||
-        true
+        Guest.can?(:download_code, project) ||
-      else
+        raise(UnauthorizedError, ERROR_MESSAGES[:download])
-        raise UnauthorizedError, ERROR_MESSAGES[:download]
-      end
    end
    def push_access_check(changes)