BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
e363f2e6
Commit
e363f2e6
authored
Feb 24, 2015
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix merge request URL passed to Webhooks.
Previously the symbol "url" in the object_attributes hash would always be nil.
parent
24c8381d
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
0 deletions
+18
-0
CHANGELOG
CHANGELOG
+1
-0
url_builder.rb
lib/gitlab/url_builder.rb
+9
-0
url_builder_spec.rb
spec/lib/gitlab/url_builder_spec.rb
+8
-0
No files found.
CHANGELOG
View file @
e363f2e6
Please view this file on the master branch, on stable branches it's out of date.
Please view this file on the master branch, on stable branches it's out of date.
v 7.9.0 (unreleased)
v 7.9.0 (unreleased)
- Fix merge request URL passed to Webhooks. (Stan Hu)
- Move labels/milestones tabs to sidebar
- Move labels/milestones tabs to sidebar
- Upgrade Rails gem to version 4.1.9.
- Upgrade Rails gem to version 4.1.9.
- Improve error messages for file edit failures
- Improve error messages for file edit failures
...
...
lib/gitlab/url_builder.rb
View file @
e363f2e6
...
@@ -10,6 +10,8 @@ module Gitlab
...
@@ -10,6 +10,8 @@ module Gitlab
case
@type
case
@type
when
:issue
when
:issue
issue_url
(
id
)
issue_url
(
id
)
when
:merge_request
merge_request_url
(
id
)
end
end
end
end
...
@@ -22,5 +24,12 @@ module Gitlab
...
@@ -22,5 +24,12 @@ module Gitlab
project_id:
issue
.
project
,
project_id:
issue
.
project
,
host:
Gitlab
.
config
.
gitlab
[
'url'
])
host:
Gitlab
.
config
.
gitlab
[
'url'
])
end
end
def
merge_request_url
(
id
)
merge_request
=
MergeRequest
.
find
(
id
)
project_merge_request_url
(
id:
merge_request
.
id
,
project_id:
merge_request
.
project
,
host:
Gitlab
.
config
.
gitlab
[
'url'
])
end
end
end
end
end
spec/lib/gitlab/url_builder_spec.rb
View file @
e363f2e6
...
@@ -8,4 +8,12 @@ describe Gitlab::UrlBuilder do
...
@@ -8,4 +8,12 @@ describe Gitlab::UrlBuilder do
expect
(
url
).
to
eq
"
#{
Settings
.
gitlab
[
'url'
]
}
/
#{
issue
.
project
.
path_with_namespace
}
/issues/
#{
issue
.
iid
}
"
expect
(
url
).
to
eq
"
#{
Settings
.
gitlab
[
'url'
]
}
/
#{
issue
.
project
.
path_with_namespace
}
/issues/
#{
issue
.
iid
}
"
end
end
end
end
describe
'When asking for an merge request'
do
it
'returns the merge request url'
do
merge_request
=
create
(
:merge_request
)
url
=
Gitlab
::
UrlBuilder
.
new
(
:merge_request
).
build
(
merge_request
.
id
)
expect
(
url
).
to
eq
"
#{
Settings
.
gitlab
[
'url'
]
}
/
#{
merge_request
.
project
.
to_param
}
/merge_requests/
#{
merge_request
.
id
}
"
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment