Fix bug where transferring a project would result in stale commit links

Transferring a project to another namespace updates the project's updated_at field, but since the cache key did not depend on the object, the page fragments were not invalidated. This resulted in stale links to the commits. Changing the cache key to use the object pathname solves this issue. Closes gitlab-org/omnibus-gitlab#843

Fix bug where transferring a project would result in stale commit links
dbc85bfa · Stan Hu · b5c12f74 · dbc85bfa · dbc85bfa
Commit dbc85bfa authored Oct 01, 2015 by Stan Hu
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

CHANGELOG CHANGELOG +1 -0

_commit.html.haml app/views/projects/commits/_commit.html.haml +1 -1

No files found.
--- a/CHANGELOG
+++ b/CHANGELOG
 Please view this file on the master branch, on stable branches it's out of date.

 v 8.1.0 (unreleased)
+  - Fix bug where transferring a project would result in stale commit links (Stan Hu)
  - Include full path of source and target branch names in New Merge Request page (Stan Hu)
  - Fix Message-ID header to be RFC 2111-compliant to prevent e-mails being dropped (Stan Hu)
  - Add user preference to view activities as default dashboard (Stan Hu)

--- a/app/views/projects/commits/_commit.html.haml
+++ b/app/views/projects/commits/_commit.html.haml
@@ -5,7 +5,7 @@
  - note_count = notes.user.count

 - ci_commit = project.ci_commit(commit.sha)
- cache_key = [project.id, commit.id, note_count]
+- cache_key = [project.path_with_namespace, commit.id, note_count]
 - cache_key.push(ci_commit.status) if ci_commit

 = cache(cache_key) do