BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
d514e91c
Commit
d514e91c
authored
Nov 29, 2017
by
Douwe Maan
Committed by
Tiago
Nov 29, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Merge branch 'events-atom-feed-author-query' into 'master'
Reuse authors when rendering event Atom feeds See merge request gitlab-org/gitlab-ce!15630 (cherry picked from commit
a2fea928
)
63180167
Reuse authors when rendering event Atom feeds
parent
d1945078
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
1 deletion
+11
-1
_event.atom.builder
app/views/events/_event.atom.builder
+6
-1
events-atom-feed-author-query.yml
changelogs/unreleased/events-atom-feed-author-query.yml
+5
-0
No files found.
app/views/events/_event.atom.builder
View file @
d514e91c
...
...
@@ -5,7 +5,12 @@ xml.entry do
xml.link href: event_feed_url(event)
xml.title truncate(event_feed_title(event), length: 80)
xml.updated event.updated_at.xmlschema
xml.media :thumbnail, width: "40", height: "40", url: image_url(avatar_icon(event.author_email))
# We're deliberately re-using "event.author" here since this data is
# eager-loaded. This allows us to re-use the user object's Email address,
# instead of having to run additional queries to figure out what Email to use
# for the avatar.
xml.media :thumbnail, width: "40", height: "40", url: image_url(avatar_icon(event.author))
xml.author do
xml.username event.author_username
...
...
changelogs/unreleased/events-atom-feed-author-query.yml
0 → 100644
View file @
d514e91c
---
title
:
Reuse authors when rendering event Atom feeds
merge_request
:
author
:
type
:
performance
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment