BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
d30e71b3
Commit
d30e71b3
authored
Feb 05, 2018
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix tests for Drop filename enforcement
parent
8bf94381
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
17 deletions
+1
-17
create_trace_artifact_service_spec.rb
spec/services/ci/create_trace_artifact_service_spec.rb
+1
-1
job_artifact_uploader_spec.rb
spec/uploaders/job_artifact_uploader_spec.rb
+0
-16
No files found.
spec/services/ci/create_trace_artifact_service_spec.rb
View file @
d30e71b3
...
@@ -19,7 +19,7 @@ describe Ci::CreateTraceArtifactService do
...
@@ -19,7 +19,7 @@ describe Ci::CreateTraceArtifactService do
it
'creates trace artifact'
do
it
'creates trace artifact'
do
expect
{
subject
}.
to
change
{
Ci
::
JobArtifact
.
count
}.
by
(
1
)
expect
{
subject
}.
to
change
{
Ci
::
JobArtifact
.
count
}.
by
(
1
)
expect
(
job
.
job_artifacts_trace
.
read_attribute
(
:file
)).
to
eq
(
'
trace.log
'
)
expect
(
job
.
job_artifacts_trace
.
read_attribute
(
:file
)).
to
eq
(
'
sample_trace
'
)
end
end
context
'when the job has already had trace artifact'
do
context
'when the job has already had trace artifact'
do
...
...
spec/uploaders/job_artifact_uploader_spec.rb
View file @
d30e71b3
...
@@ -38,22 +38,6 @@ describe JobArtifactUploader do
...
@@ -38,22 +38,6 @@ describe JobArtifactUploader do
end
end
end
end
describe
'#filename'
do
subject
{
uploader
.
filename
}
context
'when artifact file_type is archive'
do
let
(
:job_artifact
)
{
create
(
:ci_job_artifact
,
:archive
)
}
it
{
is_expected
.
to
be_nil
}
end
context
'when artifact file_type is trace'
do
let
(
:job_artifact
)
{
create
(
:ci_job_artifact
,
:trace
)
}
it
{
is_expected
.
to
eq
(
'trace.log'
)
}
end
end
context
'file is stored in valid local_path'
do
context
'file is stored in valid local_path'
do
let
(
:file
)
do
let
(
:file
)
do
fixture_file_upload
(
fixture_file_upload
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment