Merge branch 'fix_test_env' into 'master'

Fix Test Env (proper error handling when gitlab-shell is not clonned) ## What does this MR do? If we were not able to clone gitlab-shell we have to stop all test suite, for now we run it regardless we cloned it or not. ## Why was this MR needed? To not confuse developers when build is red, to get fasts feedback, to save resources and time. See merge request !6933

Merge branch 'fix_test_env' into 'master'
d2591df1 · Dmitriy Zaporozhets · 0f5c31d5 · 7762d8f5 · d2591df1
Commit d2591df1 authored Oct 17, 2016 by Dmitriy Zaporozhets
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

test_env.rb spec/support/test_env.rb +3 -1

No files found.
--- a/spec/support/test_env.rb
+++ b/spec/support/test_env.rb
@@ -98,7 +98,9 @@ module TestEnv

  def setup_gitlab_shell
    unless File.directory?(Gitlab.config.gitlab_shell.path)
-      `rake gitlab:shell:install`
+      unless system('rake', 'gitlab:shell:install')
+        raise 'Can`t clone gitlab-shell'
+      end
    end
  end