Speed up dashboard milestone index by scoping IssuesFinder to user authorized projects

It improves performance in dashboard milestone index page by passing a hint to "IssuesFinder". "IssuesFinder" generates a more performant query when it is limited to authorized projects for user. In the dashboard we already limit the projects to these authorized for user (see "Dashboard::ApplicationController#projects"), so we can safely pass this option to "IssuesFinder".

Speed up dashboard milestone index by scoping IssuesFinder to user authorized projects
cf3be218 · Adam Niedzielski · 0ff88ac5 · cf3be218 · cf3be218 · cf3be218
Commit cf3be218 authored Jan 13, 2017 by Adam Niedzielski
3 changed files
--- a/app/controllers/dashboard/milestones_controller.rb
+++ b/app/controllers/dashboard/milestones_controller.rb
@@ -19,11 +19,11 @@ class Dashboard::MilestonesController < Dashboard::ApplicationController
  private
  def milestones
-    @milestones = GlobalMilestone.build_collection(@projects, params)
+    @milestones = DashboardMilestone.build_collection(@projects, params)
  end
  def milestone
-    @milestone = GlobalMilestone.build(@projects, params[:title])
+    @milestone = DashboardMilestone.build(@projects, params[:title])
    render_404 unless @milestone
  end
 end
--- a/app/models/dashboard_milestone.rb
+++ b/app/models/dashboard_milestone.rb
+class DashboardMilestone < GlobalMilestone
+  def issues_finder_params
+    { authorized_only: true }
+  end
+end
--- a/changelogs/unreleased/speed-up-dashboard-milestone-index.yml
+++ b/changelogs/unreleased/speed-up-dashboard-milestone-index.yml
+---
+title: Speed up dashboard milestone index by scoping IssuesFinder to user authorized
+  projects
+merge_request: 8524
+author: