Refactor max_size method in update pages service

As per review feedback https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13072#note_35853177

Refactor max_size method in update pages service
cb405aa4 · Grzegorz Bizon · 7151fb75 · cb405aa4
Commit cb405aa4 authored Jul 26, 2017 by Grzegorz Bizon
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

update_pages_service.rb app/services/projects/update_pages_service.rb +5 -3

No files found.
--- a/app/services/projects/update_pages_service.rb
+++ b/app/services/projects/update_pages_service.rb
@@ -130,9 +130,11 @@ module Projects
    end

    def max_size
-      current_application_settings.max_pages_size.megabytes.tap do |maximum|
-        return MAX_SIZE if maximum.zero? || maximum > MAX_SIZE
-      end
+      max_pages_size = current_application_settings.max_pages_size.megabytes
+
+      return MAX_SIZE if max_pages_size.zero?
+
+      [max_pages_size, MAX_SIZE].min
    end

    def tmp_path