Return the external issue tracker even if it's null

This solves the problem with caching the nil value with instance variable. Without this the every time we ask for external_issue_tracker we built AR and potentially do SQL query

Return the external issue tracker even if it's null
c51c9019 · Kamil Trzcinski · 94031420 · c51c9019
Commit c51c9019 authored Mar 15, 2016 by Kamil Trzcinski
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

project.rb app/models/project.rb +1 -0

No files found.
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -508,6 +508,7 @@ class Project < ActiveRecord::Base
  end

  def external_issue_tracker
+    return @external_issue_tracker if defined?(@external_issue_tracker)
    @external_issue_tracker ||=
      services.issue_trackers.active.without_defaults.first
  end