Use let! feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173336 let! is not very flexible but I guess it's fine since this is not in top-level anyway.

Use let! feedback:
c3c0406a · Lin Jen-Shin · cd449a73 · c3c0406a
Commit c3c0406a authored Jul 20, 2016 by Lin Jen-Shin
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 5 deletions

build_spec.rb spec/models/build_spec.rb +1 -5

No files found.
--- a/spec/models/build_spec.rb
+++ b/spec/models/build_spec.rb
@@ -675,14 +675,10 @@ describe Ci::Build, models: true do
  end

  describe 'Project#latest_successful_builds_for' do
-    let(:build) do
+    let!(:build) do
      create(:ci_build, :artifacts, :success, pipeline: pipeline)
    end

-    before do
-      build
-    end
-
    context 'with succeed pipeline' do
      it 'returns builds from ref' do
        builds = project.latest_successful_builds_for('fix')