Eliminate N+1 queries in loading namespaces for every issuable in milestones

If we rely on the helper functions in `GitlabRoutingHelper` for `merge_request_path`, we end up calling a database query to look up the Namespace association for every merge request since `entity.project.namespace` is called. By reusing the project defined in the controller, we avoid that problem. Partial fix to #27387

Eliminate N+1 queries in loading namespaces for every issuable in milestones
bbcb7e5e · Stan Hu · 1005389f · bbcb7e5e · bbcb7e5e
Commit bbcb7e5e authored Apr 23, 2017 by Stan Hu
Showing with 5 additions and 1 deletion

_issuable.html.haml app/views/shared/milestones/_issuable.html.haml +1 -1

sh-optimize-milestone-polymorphic-url.yml ...logs/unreleased/sh-optimize-milestone-polymorphic-url.yml +4 -0

No files found.
--- a/app/views/shared/milestones/_issuable.html.haml
+++ b/app/views/shared/milestones/_issuable.html.haml
@@ -5,7 +5,7 @@
 - base_url_args = [project.namespace.becomes(Namespace), project, issuable_type]
 - can_update = can?(current_user, :"update_#{issuable.to_ability_name}", issuable)
-%li{ id: dom_id(issuable, 'sortable'),  class: "issuable-row #{'is-disabled' unless can_update}", 'data-iid' => issuable.iid, 'data-id' => issuable.id, 'data-url' => polymorphic_path(issuable) }
+%li{ id: dom_id(issuable, 'sortable'),  class: "issuable-row #{'is-disabled' unless can_update}", 'data-iid' => issuable.iid, 'data-id' => issuable.id, 'data-url' => polymorphic_path([project.namespace.becomes(Namespace), project, issuable]) }
  %span
    - if show_project_name
      %strong #{project.name} &middot;

--- a/changelogs/unreleased/sh-optimize-milestone-polymorphic-url.yml
+++ b/changelogs/unreleased/sh-optimize-milestone-polymorphic-url.yml
+---
+title: Eliminate N+1 queries in loading namespaces for every issuable in milestones
+merge_request:
+author: