Simplify ProjectTeam#fetch_members to satisfy flog

app/models/project_team.rb

@@ -163,7 +163,7 @@ class ProjectTeam
 
       # Each group produces a list of maximum access level per user. We take the
       # max of the values produced by each group.
-      if project.invited_groups.any? && project.allowed_to_share_with_group?
+      if project_shared_with_group?
         project.project_group_links.each do |group_link|
           invited_access = max_invited_level_for_users(group_link, user_ids)
           merge_max!(access, invited_access)
@@ -200,9 +200,39 @@ class ProjectTeam
   def fetch_members(level = nil)
     project_members = project.members
     group_members = group ? group.members : []
+
+    if level
+      project_members = project_members.send(level)
+      group_members = group_members.send(level) if group
+    end
+
+    user_ids = project_members.pluck(:user_id)
+
+    invited_members = fetch_invited_members(level)
+    user_ids.push(*invited_members.map(&:user_id)) if invited_members.any?
+
+    user_ids.push(*group_members.pluck(:user_id)) if group
+
+    User.where(id: user_ids)
+  end
+
+  def group
+    project.group
+  end
+
+  def merge_max!(first_hash, second_hash)
+    first_hash.merge!(second_hash) { |_key, old, new| old > new ? old : new }
+  end
+
+  def project_shared_with_group?
+    project.invited_groups.any? && project.allowed_to_share_with_group?
+  end
+
+  def fetch_invited_members(level = nil)
     invited_members = []
 
-    if project.invited_groups.any? && project.allowed_to_share_with_group?
+    return invited_members unless project_shared_with_group?
+
     project.project_group_links.includes(group: [:group_members]).each do |group_link|
       invited_group = group_link.group
       im = invited_group.members
@@ -227,26 +257,6 @@ class ProjectTeam
       invited_members << im
     end
 
-      invited_members = invited_members.flatten.compact
-    end
-
-    if level
-      project_members = project_members.send(level)
-      group_members = group_members.send(level) if group
-    end
-
-    user_ids = project_members.pluck(:user_id)
-    user_ids.push(*invited_members.map(&:user_id)) if invited_members.any?
-    user_ids.push(*group_members.pluck(:user_id)) if group
-
-    User.where(id: user_ids)
-  end
-
-  def group
-    project.group
-  end
-
-  def merge_max!(first_hash, second_hash)
-    first_hash.merge!(second_hash) { |_key, old, new| old > new ? old : new }
+    invited_members.flatten.compact
   end
 end