BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
b0aec417
Commit
b0aec417
authored
Jan 25, 2017
by
Fatih Acet
Committed by
Robert Speicher
Jan 27, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Merge branch 'label-select-toggle' into 'master'
Fixed label select toggle not updating correctly Closes #26119 See merge request !8601
parent
8829bf18
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
25 additions
and
1 deletion
+25
-1
labels_select.js
app/assets/javascripts/labels_select.js
+5
-1
label-select-toggle.yml
changelogs/unreleased/label-select-toggle.yml
+4
-0
form_spec.rb
spec/features/issues/form_spec.rb
+16
-0
No files found.
app/assets/javascripts/labels_select.js
View file @
b0aec417
...
...
@@ -336,7 +336,11 @@
.
removeClass
(
'is-active'
)
}
if
(
$dropdown
.
hasClass
(
'js-filter-bulk-update'
)
||
$dropdown
.
hasClass
(
'js-issuable-form-dropdown'
))
{
if
(
$dropdown
.
hasClass
(
'js-issuable-form-dropdown'
))
{
return
;
}
if
(
$dropdown
.
hasClass
(
'js-filter-bulk-update'
))
{
_this
.
enableBulkLabelDropdown
();
_this
.
setDropdownData
(
$dropdown
,
isMarking
,
this
.
id
(
label
));
return
;
...
...
changelogs/unreleased/label-select-toggle.yml
0 → 100644
View file @
b0aec417
---
title
:
Fixed label dropdown toggle text not correctly updating
merge_request
:
author
:
spec/features/issues/form_spec.rb
View file @
b0aec417
...
...
@@ -68,6 +68,22 @@ describe 'New/edit issue', feature: true, js: true do
end
end
end
it
'correctly updates the dropdown toggle when removing a label'
do
click_button
'Labels'
page
.
within
'.dropdown-menu-labels'
do
click_link
label
.
title
end
expect
(
find
(
'.js-label-select'
)).
to
have_content
(
label
.
title
)
page
.
within
'.dropdown-menu-labels'
do
click_link
label
.
title
end
expect
(
find
(
'.js-label-select'
)).
to
have_content
(
'Labels'
)
end
end
context
'edit issue'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment