Speed up searching for text references a bit

If a node is ignored there's no need for searching for a given pattern. In turn, when searching for the pattern there's no need to construct a MatchData object as we only care about presence (or lack thereof), not the resulting matches. In terms of performance this cuts down about 200 ms when loading issue #2164 locally, though this varies a bit depending on system load.

Speed up searching for text references a bit
afdc0285 · Yorick Peterse · 97eafd4b · afdc0285 · afdc0285
Commit afdc0285 authored Oct 20, 2015 by Yorick Peterse
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

CHANGELOG CHANGELOG +1 -0

reference_filter.rb lib/gitlab/markdown/reference_filter.rb +4 -4

No files found.
--- a/CHANGELOG
+++ b/CHANGELOG
 Please view this file on the master branch, on stable branches it's out of date.

 v 8.2.0 (unreleased)
+  - Improved performance of replacing references in comments
  - Fix duplicate repositories in GitHub import page (Stan Hu)
  - Show last project commit to default branch on project home page
  - Highlight comment based on anchor in URL

--- a/lib/gitlab/markdown/reference_filter.rb
+++ b/lib/gitlab/markdown/reference_filter.rb
@@ -15,7 +15,7 @@ module Gitlab
      LazyReference = Struct.new(:klass, :ids) do
        def self.load(refs)
          lazy_references, values = refs.partition { |ref| ref.is_a?(self) }
-          
+
          lazy_values = lazy_references.group_by(&:klass).flat_map do |klass, refs|
            ids = refs.flat_map(&:ids)
            klass.where(id: ids)
@@ -107,10 +107,10 @@ module Gitlab
        return doc if project.nil?

        search_text_nodes(doc).each do |node|
-          content = node.to_html
-
-          next unless content.match(pattern)
          next if ignored_ancestry?(node)
+          next unless node.text =~ pattern
+
+          content = node.to_html

          html = yield content