BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
afb69488
Commit
afb69488
authored
Mar 13, 2015
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'ldap-unblock-user' into 'master'
Unblock user if they were unblocked in AD. Fixes problem with !1687. See merge request !1694
parents
48036751
8fed4352
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
1 deletion
+12
-1
CHANGELOG
CHANGELOG
+1
-0
access.rb
lib/gitlab/ldap/access.rb
+1
-0
access_spec.rb
spec/lib/gitlab/ldap/access_spec.rb
+10
-1
No files found.
CHANGELOG
View file @
afb69488
...
...
@@ -65,6 +65,7 @@ v 7.9.0 (unreleased)
- Fix import pages not working after first load.
- Use custom LDAP label in LDAP signin form.
- Execute hooks and services when branch or tag is created or deleted through web interface.
- Block and unblock user if he/she was blocked/unblocked in Active Directory
v 7.8.4
- Fix issue_tracker_id substitution in custom issue trackers
...
...
lib/gitlab/ldap/access.rb
View file @
afb69488
...
...
@@ -40,6 +40,7 @@ module Gitlab
user
.
block
unless
user
.
blocked?
false
else
user
.
activate
if
user
.
blocked?
true
end
else
...
...
spec/lib/gitlab/ldap/access_spec.rb
View file @
afb69488
...
...
@@ -28,9 +28,18 @@ describe Gitlab::LDAP::Access do
end
context
'and has no disabled flag in active diretory'
do
before
{
Gitlab
::
LDAP
::
Person
.
stub
(
disabled_via_active_directory?:
false
)
}
before
do
user
.
block
Gitlab
::
LDAP
::
Person
.
stub
(
disabled_via_active_directory?:
false
)
end
it
{
is_expected
.
to
be_truthy
}
it
"should unblock user in GitLab"
do
access
.
allowed?
user
.
should_not
be_blocked
end
end
context
'without ActiveDirectory enabled'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment