[Rails5] Fix admin/application_settings_controller

The `RAILS5=1 rspec spec/controllers/admin/application_settings_controller_spec.rb` command throws the error: Failures: 1) Admin::ApplicationSettingsController PUT #update falls back to defaults when settings are omitted Failure/Error: import_sources = params[:application_setting][:import_sources] NoMethodError: undefined method `[]' for nil:NilClass # ./app/controllers/admin/application_settings_controller.rb:62:in `application_setting_params' This commit fixes it.

[Rails5] Fix admin/application_settings_controller
ac1b5def · blackst0ne · 6b246360 · ac1b5def
Commit ac1b5def authored Apr 11, 2018 by blackst0ne
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

application_settings_controller.rb app/controllers/admin/application_settings_controller.rb +2 -0

No files found.
--- a/app/controllers/admin/application_settings_controller.rb
+++ b/app/controllers/admin/application_settings_controller.rb
@@ -56,7 +56,9 @@ class Admin::ApplicationSettingsController < Admin::ApplicationController
  end

  def application_setting_params
+    params[:application_setting] ||= {}
    import_sources = params[:application_setting][:import_sources]
+
    if import_sources.nil?
      params[:application_setting][:import_sources] = []
    else