Cleanup let a bit, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195683 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195692 another_artifacts was no longer used and then there's no point to put let in outer scope anymore.

Cleanup let a bit, feedback:
a9f3f3c8 · Lin Jen-Shin · 145da6b1 · a9f3f3c8
Commit a9f3f3c8 authored Jul 20, 2016 by Lin Jen-Shin
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 5 deletions

builds_spec.rb spec/requests/api/builds_spec.rb +1 -5

No files found.
--- a/spec/requests/api/builds_spec.rb
+++ b/spec/requests/api/builds_spec.rb
@@ -213,17 +213,13 @@ describe API::API, api: true do
    end

    context 'find proper build' do
-      let(:another_artifacts) do
-        fixture_file_upload(Rails.root + 'spec/fixtures/dk.png', 'image/gif')
-      end
-
+      shared_examples 'a valid file' do
        let(:download_headers) do
          { 'Content-Transfer-Encoding' => 'binary',
            'Content-Disposition' =>
              "attachment; filename=#{build.artifacts_file.filename}" }
        end

-      shared_examples 'a valid file' do
        it { expect(response).to have_http_status(200) }
        it { expect(response.headers).to include(download_headers) }
      end