Merge branch 'rs-banzai-requires' into 'master'

Remove redundant `require`s from Banzai files We're trying to avoid circular dependency errors. Related: https://gitlab.com/gitlab-org/gitlab-ce/issues/13521 Sentry: https://sentry.gitlap.com/gitlab/gitlabcom/issues/8/ See merge request !3391

Merge branch 'rs-banzai-requires' into 'master'
a9346cab · Rémy Coutable · 4a439856 · 85584834 · a9346cab · a9346cab
Commit a9346cab authored Mar 30, 2016 by Rémy Coutable
18 changed files
--- a/lib/banzai/filter.rb
+++ b/lib/banzai/filter.rb
-require 'active_support/core_ext/string/output_safety'
-
 module Banzai
  module Filter
    def self.[](name)

--- a/lib/banzai/filter/autolink_filter.rb
+++ b/lib/banzai/filter/autolink_filter.rb
-require 'html/pipeline/filter'
 require 'uri'

 module Banzai

--- a/lib/banzai/filter/emoji_filter.rb
+++ b/lib/banzai/filter/emoji_filter.rb
-require 'action_controller'
-require 'gitlab_emoji'
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # HTML filter that replaces :emoji: with images.

--- a/lib/banzai/filter/external_link_filter.rb
+++ b/lib/banzai/filter/external_link_filter.rb
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # HTML Filter to add a `rel="nofollow"` attribute to external links

--- a/lib/banzai/filter/gollum_tags_filter.rb
+++ b/lib/banzai/filter/gollum_tags_filter.rb
-require 'banzai'
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # HTML Filter for parsing Gollum's tags in HTML. It's only parses the

--- a/lib/banzai/filter/markdown_filter.rb
+++ b/lib/banzai/filter/markdown_filter.rb
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    class MarkdownFilter < HTML::Pipeline::TextFilter

--- a/lib/banzai/filter/milestone_reference_filter.rb
+++ b/lib/banzai/filter/milestone_reference_filter.rb
-require 'banzai'
-
 module Banzai
  module Filter
    # HTML filter that replaces milestone references with links.

--- a/lib/banzai/filter/redactor_filter.rb
+++ b/lib/banzai/filter/redactor_filter.rb
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # HTML filter that removes references to records that the current user does

--- a/lib/banzai/filter/reference_filter.rb
+++ b/lib/banzai/filter/reference_filter.rb
-require 'active_support/core_ext/string/output_safety'
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # Base class for GitLab Flavored Markdown reference filters.

--- a/lib/banzai/filter/reference_gatherer_filter.rb
+++ b/lib/banzai/filter/reference_gatherer_filter.rb
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # HTML filter that gathers all referenced records that the current user has

--- a/lib/banzai/filter/relative_link_filter.rb
+++ b/lib/banzai/filter/relative_link_filter.rb
-require 'html/pipeline/filter'
 require 'uri'

 module Banzai

--- a/lib/banzai/filter/sanitization_filter.rb
+++ b/lib/banzai/filter/sanitization_filter.rb
-require 'html/pipeline/filter'
-require 'html/pipeline/sanitization_filter'
-
 module Banzai
  module Filter
    # Sanitize HTML

--- a/lib/banzai/filter/syntax_highlight_filter.rb
+++ b/lib/banzai/filter/syntax_highlight_filter.rb
-require 'html/pipeline/filter'
 require 'rouge/plugins/redcarpet'

 module Banzai

--- a/lib/banzai/filter/table_of_contents_filter.rb
+++ b/lib/banzai/filter/table_of_contents_filter.rb
-require 'html/pipeline/filter'
-
 module Banzai
  module Filter
    # HTML filter that adds an anchor child element to all Headers in a

--- a/lib/banzai/filter/upload_link_filter.rb
+++ b/lib/banzai/filter/upload_link_filter.rb
-require 'html/pipeline/filter'
 require 'uri'

 module Banzai

--- a/lib/banzai/filter/yaml_front_matter_filter.rb
+++ b/lib/banzai/filter/yaml_front_matter_filter.rb
-require 'html/pipeline/filter'
-require 'yaml'
-
 module Banzai
  module Filter
    class YamlFrontMatterFilter < HTML::Pipeline::Filter

--- a/lib/banzai/pipeline/base_pipeline.rb
+++ b/lib/banzai/pipeline/base_pipeline.rb
-require 'html/pipeline'
-
 module Banzai
  module Pipeline
    class BasePipeline

--- a/lib/banzai/pipeline/wiki_pipeline.rb
+++ b/lib/banzai/pipeline/wiki_pipeline.rb
-require 'banzai'
-
 module Banzai
  module Pipeline
    class WikiPipeline < FullPipeline