BigW Consortium Gitlab

Make RepoEditor an async component to load monaco before mounting

parent 98ad6706
......@@ -9,7 +9,7 @@ import RepoCommitSection from './repo_commit_section.vue';
import RepoTabs from './repo_tabs.vue';
import RepoFileButtons from './repo_file_buttons.vue';
import RepoBinaryViewer from './repo_binary_viewer.vue';
import RepoEditor from './repo_editor.vue';
import RepoEditor from './repo_editor';
import RepoMiniMixin from './repo_mini_mixin';
function initRepo() {
......
<script>
/* global monaco */
import Store from './repo_store';
import Helper from './repo_helper';
......@@ -7,9 +6,10 @@ import monacoLoader from './monaco_loader';
const RepoEditor = {
data: () => Store,
template: '<div id="ide"></div>',
mounted() {
monacoLoader(['vs/editor/editor.main'], () => {
const monacoInstance = monaco.editor.create(this.$el, {
const monacoInstance = this.monaco.editor.create(this.$el, {
model: null,
readOnly: true,
contextmenu: false,
......@@ -24,11 +24,10 @@ const RepoEditor = {
if (this.blobRaw === '') return;
const newModel = monaco.editor.createModel(this.blobRaw, 'plaintext');
const newModel = this.monaco.editor.createModel(this.blobRaw, 'plaintext');
this.monacoInstance.setModel(newModel);
}).catch(Helper.loadingError);
});
},
methods: {
......@@ -98,18 +97,23 @@ const RepoEditor = {
this.monacoInstance.setModel(null);
const languages = monaco.languages.getLanguages();
const languages = this.monaco.languages.getLanguages();
const languageID = Helper.getLanguageIDForFile(this.activeFile, languages);
const newModel = monaco.editor.createModel(this.blobRaw, languageID);
const newModel = this.monaco.editor.createModel(this.blobRaw, languageID);
this.monacoInstance.setModel(newModel);
},
},
};
export default RepoEditor;
</script>
function asyncLoadRepoEditor() {
return new Promise((resolve) => {
monacoLoader(['vs/editor/editor.main'], () => {
Store.monaco = monaco;
resolve(RepoEditor);
});
});
}
<template>
<div id="ide"></div>
</template>
export default asyncLoadRepoEditor;
......@@ -3,6 +3,7 @@ import RepoHelper from './repo_helper';
const RepoStore = {
ideEl: {},
monaco: {},
monacoInstance: {},
service: '',
editor: '',
......
import Vue from 'vue';
import repoEditor from '~/repo/repo_editor.vue';
import repoEditor from '~/repo/repo_editor';
describe('RepoEditor', () => {
function createComponent() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment