Restore Unspecified and we could discuss later

lib/gitlab/ci/config/entry/factory.rb

@@ -37,7 +37,9 @@ module Gitlab
             # See issue #18775.
             #
             if @value.nil?
+              Entry::Unspecified.new(
                 fabricate_unspecified
+              )
             else
               fabricate(@entry, @value)
             end
@@ -54,7 +56,7 @@ module Gitlab
               fabricate(Entry::Undefined)
             else
               fabricate(@entry, @entry.default)
-            end.tap(&:unspecify)
+            end
           end
 
           def fabricate(entry, value = nil)

lib/gitlab/ci/config/entry/node.rb

@@ -15,7 +15,6 @@ module Gitlab
             @config = config
             @metadata = metadata
             @entries = {}
-            @specified = true
 
             @validator = self.class.validator.new(self)
             @validator.validate(:new)
@@ -63,12 +62,8 @@ module Gitlab
             end
           end
 
-          def unspecify
-            @specified = false
-          end
-
           def specified?
-            @specified
+            true
           end
 
           def relevant?
@@ -76,18 +71,8 @@ module Gitlab
           end
 
           def inspect
-            val = if leaf?
-                    config
-                  else
-                    descendants
-                  end
-
-            unspecified = if specified?
-                            ''
-                          else
-                            '(unspecified) '
-                          end
-
+            val = leaf? ? config : descendants
+            unspecified = specified? ? '' : '(unspecified) '
             "#<#{self.class.name} #{unspecified}{#{key}: #{val.inspect}}>"
           end
 

lib/gitlab/ci/config/entry/unspecified.rb

+module Gitlab
+  module Ci
+    class Config
+      module Entry
+        ##
+        # This class represents an unspecified entry.
+        #
+        # It decorates original entry adding method that indicates it is
+        # unspecified.
+        #
+        class Unspecified < SimpleDelegator
+          def specified?
+            false
+          end
+        end
+      end
+    end
+  end
+end

spec/lib/gitlab/ci/config/entry/unspecified_spec.rb

+require 'spec_helper'
+
+describe Gitlab::Ci::Config::Entry::Unspecified do
+  let(:unspecified) { described_class.new(entry) }
+  let(:entry) { spy('Entry') }
+
+  describe '#valid?' do
+    it 'delegates method to entry' do
+      expect(unspecified.valid?).to eq entry
+    end
+  end
+
+  describe '#errors' do
+    it 'delegates method to entry' do
+      expect(unspecified.errors).to eq entry
+    end
+  end
+
+  describe '#value' do
+    it 'delegates method to entry' do
+      expect(unspecified.value).to eq entry
+    end
+  end
+
+  describe '#specified?' do
+    it 'is always false' do
+      allow(entry).to receive(:specified?).and_return(true)
+
+      expect(unspecified.specified?).to be false
+    end
+  end
+end