Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
9c27c90b
Commit
9c27c90b
authored
Apr 24, 2017
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename AddColumnWithDefault to ReversibleAddColumnWithDefault
We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them.
parent
bbdaf982
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
4 deletions
+4
-4
reversible_add_column_with_default.rb
rubocop/cop/migration/reversible_add_column_with_default.rb
+1
-1
rubocop.rb
rubocop/rubocop.rb
+1
-1
reversible_add_column_with_default_spec.rb
.../cop/migration/reversible_add_column_with_default_spec.rb
+2
-2
No files found.
rubocop/cop/migration/add_column_with_default.rb
→
rubocop/cop/migration/
reversible_
add_column_with_default.rb
View file @
9c27c90b
...
...
@@ -5,7 +5,7 @@ module RuboCop
module
Migration
# Cop that checks if `add_column_with_default` is used with `up`/`down` methods
# and not `change`.
class
AddColumnWithDefault
<
RuboCop
::
Cop
::
Cop
class
Reversible
AddColumnWithDefault
<
RuboCop
::
Cop
::
Cop
include
MigrationHelpers
def_node_matcher
:add_column_with_default?
,
<<~
PATTERN
...
...
rubocop/rubocop.rb
View file @
9c27c90b
require_relative
'cop/custom_error_class'
require_relative
'cop/gem_fetcher'
require_relative
'cop/migration/add_column'
require_relative
'cop/migration/add_column_with_default'
require_relative
'cop/migration/add_concurrent_foreign_key'
require_relative
'cop/migration/add_concurrent_index'
require_relative
'cop/migration/add_index'
require_relative
'cop/migration/remove_concurrent_index'
require_relative
'cop/migration/remove_index'
require_relative
'cop/migration/reversible_add_column_with_default'
spec/rubocop/cop/migration/add_column_with_default_spec.rb
→
spec/rubocop/cop/migration/
reversible_
add_column_with_default_spec.rb
View file @
9c27c90b
...
...
@@ -3,9 +3,9 @@ require 'spec_helper'
require
'rubocop'
require
'rubocop/rspec/support'
require_relative
'../../../../rubocop/cop/migration/add_column_with_default'
require_relative
'../../../../rubocop/cop/migration/
reversible_
add_column_with_default'
describe
RuboCop
::
Cop
::
Migration
::
AddColumnWithDefault
do
describe
RuboCop
::
Cop
::
Migration
::
Reversible
AddColumnWithDefault
do
include
CopHelper
subject
(
:cop
)
{
described_class
.
new
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment