Modified redirection logic in the variables cont.

Redirections now show a flash message wether the variable was created correctly or not using a flash message

Modified redirection logic in the variables cont.
9739f2c9 · Jose Ivan Vargas · c500e958 · 9739f2c9
Commit 9739f2c9 authored Feb 01, 2017 by Jose Ivan Vargas
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

variables_controller.rb app/controllers/projects/variables_controller.rb +3 -2

No files found.
--- a/app/controllers/projects/variables_controller.rb
+++ b/app/controllers/projects/variables_controller.rb
@@ -25,10 +25,11 @@ class Projects::VariablesController < Projects::ApplicationController
    @variable = Ci::Variable.new(project_params)

    if @variable.valid? && @project.variables << @variable
-      redirect_to namespace_project_settings_ci_cd_path(project.namespace, project), notice: 'Variables were successfully updated.'
+      flash[:notice] = 'Variables were successfully updated.'
    else
-      render action: "index"
+      flash[:alert] = @variable.errors.full_messages.join(',').html_safe
    end
+    redirect_to namespace_project_settings_ci_cd_path(project.namespace, project)
  end

  def destroy