Fixed bug with label filter dropdown not removing the correct label

917a5140 · Phil Hughes · 7124e510 · 917a5140
Commit 917a5140 authored Aug 11, 2016 by Phil Hughes
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

labels_select.js app/assets/javascripts/labels_select.js +5 -2

No files found.
--- a/app/assets/javascripts/labels_select.js
+++ b/app/assets/javascripts/labels_select.js
@@ -250,8 +250,11 @@
              } else if (label.title) {
                BoardsStore.state.filters['label_name'].push(label.title);
              } else {
-                var labelIndex = BoardsStore.state.filters['label_name'].indexOf(label.text());
-                BoardsStore.state.filters['label_name'].splice(labelIndex, 1);
+                var filters = BoardsStore.state.filters['label_name'];
+                filters = filters.filter(function (label) {
+                  return label !== $el.text().trim();
+                });
+                BoardsStore.state.filters['label_name'] = filters;
              }

              BoardsStore.updateFiltersUrl();