Cache Banzai class methods returning static data

These methods always return the same data for every class so there's no point in computing their values on every call.

Cache Banzai class methods returning static data
8c49eaa9 · Yorick Peterse · 14114805 · 8c49eaa9
Commit 8c49eaa9 authored Mar 24, 2016 by Yorick Peterse
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

abstract_reference_filter.rb lib/banzai/filter/abstract_reference_filter.rb +3 -3

No files found.
--- a/lib/banzai/filter/abstract_reference_filter.rb
+++ b/lib/banzai/filter/abstract_reference_filter.rb
@@ -11,15 +11,15 @@ module Banzai
      end

      def self.object_name
-        object_class.name.underscore
+        @object_name ||= object_class.name.underscore
      end

      def self.object_sym
-        object_name.to_sym
+        @object_sym ||= object_name.to_sym
      end

      def self.data_reference
-        "data-#{object_name.dasherize}"
+        @data_reference ||= "data-#{object_name.dasherize}"
      end

      # Public: Find references in text (like `!123` for merge requests)