Merge branch 'zj-fix-environments-fixtures' into 'master'

Fix enviroments seeding on certain branch names Closes #45051 See merge request gitlab-org/gitlab-ce!18263

Merge branch 'zj-fix-environments-fixtures' into 'master'
6b246360 · Robert Speicher · 37a56324 · 43b0dddf · 6b246360
Commit 6b246360 authored Apr 11, 2018 by Robert Speicher
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

19_environments.rb db/fixtures/development/19_environments.rb +5 -1

No files found.
--- a/db/fixtures/development/19_environments.rb
+++ b/db/fixtures/development/19_environments.rb
@@ -28,7 +28,11 @@ class Gitlab::Seeder::Environments
  end

  def create_merge_request_review_deployments!
-    @project.merge_requests.sample(4).map do |merge_request|
+    @project
+      .merge_requests
+      .select { |mr| mr.source_branch.match(/\p{Alnum}+/) }
+      .sample(4)
+      .each do |merge_request|
      next unless merge_request.diff_head_sha

      create_deployment!(