Relax constraint on Wiki IDs, since subdirectories can contain spaces

If a subdirectory contains spaces, GitLab would be unable to generate the route in the sidebar, resulting in an Error 500. Closes #30357

Relax constraint on Wiki IDs, since subdirectories can contain spaces
6811adaf · Stan Hu · 9fc17f6f · 6811adaf · 6811adaf
Commit 6811adaf authored Apr 01, 2017 by Stan Hu
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

sh-relax-wiki-slug-constraint.yml changelogs/unreleased/sh-relax-wiki-slug-constraint.yml +4 -0

wiki.rb config/routes/wiki.rb +1 -3

No files found.
--- a/changelogs/unreleased/sh-relax-wiki-slug-constraint.yml
+++ b/changelogs/unreleased/sh-relax-wiki-slug-constraint.yml
+---
+title: Relax constraint on Wiki IDs, since subdirectories can contain spaces
+merge_request:
+author:
--- a/config/routes/wiki.rb
+++ b/config/routes/wiki.rb
-WIKI_SLUG_ID = { id: /\S+/ }.freeze unless defined? WIKI_SLUG_ID
-
 scope(controller: :wikis) do
  scope(path: 'wikis', as: :wikis) do
    get :git_access
@@ -8,7 +6,7 @@ scope(controller: :wikis) do
    post '/', to: 'wikis#create'
  end

-  scope(path: 'wikis/*id', as: :wiki, constraints: WIKI_SLUG_ID, format: false) do
+  scope(path: 'wikis/*id', as: :wiki, format: false) do
    get :edit
    get :history
    post :preview_markdown