BigW Consortium Gitlab

Commit 64e09a1b by Grzegorz Bizon

Fix pipeline status when allowed to fail jobs present

parent bf57a7e8
...@@ -37,7 +37,9 @@ module HasStatus ...@@ -37,7 +37,9 @@ module HasStatus
end end
def status def status
all.pluck(status_sql).first all.pluck(status_sql).first.tap do |status|
return 'success' if status == 'skipped' && all.failed_but_allowed.any?
end
end end
def started_at def started_at
......
...@@ -62,6 +62,10 @@ describe Ci::ProcessPipelineService, '#execute', :services do ...@@ -62,6 +62,10 @@ describe Ci::ProcessPipelineService, '#execute', :services do
fail_running_or_pending fail_running_or_pending
expect(builds_statuses).to eq %w(failed pending) expect(builds_statuses).to eq %w(failed pending)
fail_running_or_pending
expect(pipeline.reload).to be_success
end end
end end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment