BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 60d5063d by Clement Ho
Options

Merge branch 'winh-testing-promises-docs' into 'master'

Minor changes to Testing Promises section See merge request !11517
parents baa6a089 fe3458e3
Showing with 7 additions and 6 deletions
doc/development/fe_guide/testing.md
...@@ -74,7 +74,7 @@ When testing Promises you should always make sure that the test is asynchronous ...@@ -74,7 +74,7 @@ When testing Promises you should always make sure that the test is asynchronous
Your Promise chain should therefore end with a call of the `done` callback and `done.fail` in case an error occurred. Your Promise chain should therefore end with a call of the `done` callback and `done.fail` in case an error occurred.
```javascript ```javascript
/// Good // Good
it('tests a promise', (done) => { it('tests a promise', (done) => {
promise promise
.then((data) => { .then((data) => {
...@@ -84,9 +84,10 @@ it('tests a promise', (done) => { ...@@ -84,9 +84,10 @@ it('tests a promise', (done) => {
.catch(done.fail); .catch(done.fail);
}); });
/// Good // Good
it('tests a promise rejection', (done) => { it('tests a promise rejection', (done) => {
promise promise
.then(done.fail)
.catch((error) => { .catch((error) => {
expect(error).toBe(expectedError); expect(error).toBe(expectedError);
}) })
...@@ -94,7 +95,7 @@ it('tests a promise rejection', (done) => { ...@@ -94,7 +95,7 @@ it('tests a promise rejection', (done) => {
.catch(done.fail); .catch(done.fail);
}); });
/// Bad (missing done callback) // Bad (missing done callback)
it('tests a promise', () => { it('tests a promise', () => {
promise promise
.then((data) => { .then((data) => {
...@@ -102,7 +103,7 @@ it('tests a promise', () => { ...@@ -102,7 +103,7 @@ it('tests a promise', () => {
}) })
}); });
/// Bad (missing catch) // Bad (missing catch)
it('tests a promise', (done) => { it('tests a promise', (done) => {
promise promise
.then((data) => { .then((data) => {
...@@ -111,7 +112,7 @@ it('tests a promise', (done) => { ...@@ -111,7 +112,7 @@ it('tests a promise', (done) => {
.then(done) .then(done)
}); });
/// Bad (use done.fail in asynchronous tests) // Bad (use done.fail in asynchronous tests)
it('tests a promise', (done) => { it('tests a promise', (done) => {
promise promise
.then((data) => { .then((data) => {
...@@ -121,7 +122,7 @@ it('tests a promise', (done) => { ...@@ -121,7 +122,7 @@ it('tests a promise', (done) => {
.catch(fail) .catch(fail)
}); });
/// Bad (missing catch) // Bad (missing catch)
it('tests a promise rejection', (done) => { it('tests a promise rejection', (done) => {
promise promise
.catch((error) => { .catch((error) => {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment