Freeze the expression instead of the literal

Also remove the spec for it

Freeze the expression instead of the literal
5ffec2c9 · Zeger-Jan van de Weg · be339986 · 5ffec2c9 · be339986
Commit 5ffec2c9 authored Nov 03, 2015 by Zeger-Jan van de Weg
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 11 deletions

git.rb lib/gitlab/git.rb +1 -2

git_spec.rb spec/lib/gitlab/git_spec.rb +0 -9

No files found.
--- a/lib/gitlab/git.rb
+++ b/lib/gitlab/git.rb
 module Gitlab
  module Git
-    # '0' * 40 -- this was easyer to freeze
-    BLANK_SHA = "0000000000000000000000000000000000000000".freeze
+    BLANK_SHA = ('0' * 40).freeze
    TAG_REF_PREFIX = "refs/tags/".freeze
    BRANCH_REF_PREFIX = "refs/heads/".freeze


--- a/spec/lib/gitlab/git_spec.rb
+++ b/spec/lib/gitlab/git_spec.rb
-require 'spec_helper'
-
-describe Gitlab::Git do
-  describe "BLANK_SHA" do
-    it "is a string of 40 zero's" do
-      expect(Gitlab::Git::BLANK_SHA).to eq('0' * 40)
-    end
-  end
-end