BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 58dd4a09 by blackst0ne
Options

Refactor `add_recipients`

parent b8c098ec
Showing with 2 additions and 3 deletions
app/services/notification_recipient_service.rb
...@@ -51,11 +51,10 @@ module NotificationRecipientService ...@@ -51,11 +51,10 @@ module NotificationRecipientService
def add_recipients(users, type, reason) def add_recipients(users, type, reason)
if users.is_a?(ActiveRecord::Relation) if users.is_a?(ActiveRecord::Relation)
users = users.includes(:notification_settings).to_a users = users.includes(:notification_settings)
end end
users = Array(users) users = Array(users).compact
users.compact!
recipients.concat(users.map { |u| make_recipient(u, type, reason) }) recipients.concat(users.map { |u| make_recipient(u, type, reason) })
end end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment