Only load autocomplete data when actually needed

Previously this would result in autocomplete data being loaded for every page (e.g. the page showing all Git branches of a project).

Only load autocomplete data when actually needed
569f5701 · Yorick Peterse · ce066ba6 · 569f5701 · 569f5701
Commit 569f5701 authored Jan 11, 2016 by Yorick Peterse
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

gfm_auto_complete.js.coffee app/assets/javascripts/gfm_auto_complete.js.coffee +1 -0

_init_auto_complete.html.haml app/views/layouts/_init_auto_complete.html.haml +3 -1

No files found.
--- a/app/assets/javascripts/gfm_auto_complete.js.coffee
+++ b/app/assets/javascripts/gfm_auto_complete.js.coffee
@@ -68,6 +68,7 @@ GitLab.GfmAutoComplete =
            title:  sanitize(m.title)
            search: "#{m.iid} #{m.title}"

+    if @dataSource
      $.getJSON(@dataSource).done (data) ->
        # load members
        input.atwho 'load', '@', data.members

--- a/app/views/layouts/_init_auto_complete.html.haml
+++ b/app/views/layouts/_init_auto_complete.html.haml
 - project = @target_project || @project
-:javascript
+
+- if @noteable
+  :javascript
    GitLab.GfmAutoComplete.dataSource = "#{autocomplete_sources_namespace_project_path(project.namespace, project, type: @noteable.class, type_id: params[:id])}"
    GitLab.GfmAutoComplete.setup();