BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 4a1edae3 by Lin Jen-Shin
Options

Use one query. Feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13199055
parent fcdfeba9
Showing with 2 additions and 7 deletions
app/models/project.rb
...@@ -431,13 +431,8 @@ class Project < ActiveRecord::Base ...@@ -431,13 +431,8 @@ class Project < ActiveRecord::Base
# ref can't be HEAD, can only be branch/tag name or SHA # ref can't be HEAD, can only be branch/tag name or SHA
def latest_successful_builds_for(ref = default_branch) def latest_successful_builds_for(ref = default_branch)
latest_successful_pipeline = pipelines.latest_successful_for(ref).first pipeline = pipelines.latest_successful_for(ref)
builds.where(pipeline: pipeline).latest.with_artifacts
if latest_successful_pipeline
latest_successful_pipeline.builds.with_artifacts.latest
else
builds.none
end
end end
def merge_base_commit(first_commit_id, second_commit_id) def merge_base_commit(first_commit_id, second_commit_id)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment