BigW Consortium Gitlab

Remove task abilities, since we will only ever show the user their own

parent b05ab108
class Dashboard::TasksController < Dashboard::ApplicationController class Dashboard::TasksController < Dashboard::ApplicationController
before_action :authorize_destroy_task!, only: [:destroy]
def index def index
@tasks = case params[:state] @tasks = case params[:state]
when 'done' when 'done'
...@@ -23,12 +21,6 @@ class Dashboard::TasksController < Dashboard::ApplicationController ...@@ -23,12 +21,6 @@ class Dashboard::TasksController < Dashboard::ApplicationController
private private
def authorize_destroy_task!
unless can?(current_user, :destroy_task, task)
return render_404
end
end
def task def task
@task ||= current_user.tasks.find(params[:id]) @task ||= current_user.tasks.find(params[:id])
end end
......
...@@ -17,7 +17,6 @@ class Ability ...@@ -17,7 +17,6 @@ class Ability
when Namespace then namespace_abilities(user, subject) when Namespace then namespace_abilities(user, subject)
when GroupMember then group_member_abilities(user, subject) when GroupMember then group_member_abilities(user, subject)
when ProjectMember then project_member_abilities(user, subject) when ProjectMember then project_member_abilities(user, subject)
when Task then task_abilities(user, subject)
else [] else []
end.concat(global_abilities(user)) end.concat(global_abilities(user))
end end
...@@ -417,16 +416,6 @@ class Ability ...@@ -417,16 +416,6 @@ class Ability
rules rules
end end
def task_abilities(user, task)
rules = []
if task && task.user == user
rules << :destroy_task
end
rules
end
def abilities def abilities
@abilities ||= begin @abilities ||= begin
abilities = Six.new abilities = Six.new
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment