Add retry to system hook worker

The default number of Sidekiq retries is 25 over about 21 days. If an external system is unavailable for a length of time, hooks can pile up in the Sidekiq queues. If the situation gets bad enough the retry jobs dropping back into the main queue can slow down other jobs. Limit the retries to a sane number to avoid this scenario.

Add retry to system hook worker
354e37b8 · Drew Blessing · 509ff2ab · 354e37b8 · 354e37b8
Commit 354e37b8 authored Apr 19, 2017 by Drew Blessing
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

system_hook_worker.rb app/workers/system_hook_worker.rb +2 -0

hook_retries.yml changelogs/unreleased/hook_retries.yml +4 -0

No files found.
--- a/app/workers/system_hook_worker.rb
+++ b/app/workers/system_hook_worker.rb
@@ -2,6 +2,8 @@ class SystemHookWorker
  include Sidekiq::Worker
  include DedicatedSidekiqQueue

+  sidekiq_options retry: 4
+
  def perform(hook_id, data, hook_name)
    SystemHook.find(hook_id).execute(data, hook_name)
  end

--- a/changelogs/unreleased/hook_retries.yml
+++ b/changelogs/unreleased/hook_retries.yml
+---
+title: Add retry to system hook worker
+merge_request: 10801
+author: