BigW Consortium Gitlab

Commit 283134a7 by Alfredo Sumaran

Remove unnecesary empty dialog

parent 4dbcf672
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
//= require_tree . //= require_tree .
$(() => { $(() => {
const EMPTY_DIALOG_COOKIE = 'ca_empty_dialog_dismissed';
const OVERVIEW_DIALOG_COOKIE = 'ca_overview_dialog_dismissed'; const OVERVIEW_DIALOG_COOKIE = 'ca_overview_dialog_dismissed';
const cycleAnalyticsEl = document.querySelector('#cycle-analytics'); const cycleAnalyticsEl = document.querySelector('#cycle-analytics');
const cycleAnalyticsStore = gl.cycleAnalytics.CycleAnalyticsStore; const cycleAnalyticsStore = gl.cycleAnalytics.CycleAnalyticsStore;
...@@ -20,7 +19,6 @@ $(() => { ...@@ -20,7 +19,6 @@ $(() => {
isEmptyStage: false, isEmptyStage: false,
hasError: false, hasError: false,
startDate: 30, startDate: 30,
isEmptyDialogDismissed: Cookies.get(EMPTY_DIALOG_COOKIE),
isOverviewDialogDismissed: Cookies.get(OVERVIEW_DIALOG_COOKIE), isOverviewDialogDismissed: Cookies.get(OVERVIEW_DIALOG_COOKIE),
}, },
computed: { computed: {
...@@ -104,10 +102,6 @@ $(() => { ...@@ -104,10 +102,6 @@ $(() => {
this.isLoadingStage = false; this.isLoadingStage = false;
}); });
}, },
dismissEmptyDialog() {
this.isEmptyDialogDismissed = true;
Cookies.set(EMPTY_DIALOG_COOKIE, '1');
},
dismissOverviewDialog() { dismissOverviewDialog() {
this.isOverviewDialogDismissed = true; this.isOverviewDialogDismissed = true;
Cookies.set(OVERVIEW_DIALOG_COOKIE, '1'); Cookies.set(OVERVIEW_DIALOG_COOKIE, '1');
......
%p There is nothing happened
= icon("times", class: "dismiss-icon", "@click" => "dismissEmptyDialog()")
...@@ -10,8 +10,6 @@ ...@@ -10,8 +10,6 @@
- content_for :page_specific_javascripts do - content_for :page_specific_javascripts do
= page_specific_javascript_tag("cycle_analytics/cycle_analytics_bundle.js") = page_specific_javascript_tag("cycle_analytics/cycle_analytics_bundle.js")
#cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } } #cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
.empty-dialog-message{ "v-if" => "!isEmptyDialogDismissed" }
= render partial: "empty_cycle_analytics"
.bordered-box.landing.content-block{"v-if" => "!isOverviewDialogDismissed"} .bordered-box.landing.content-block{"v-if" => "!isOverviewDialogDismissed"}
= icon("times", class: "dismiss-icon", "@click" => "dismissOverviewDialog()") = icon("times", class: "dismiss-icon", "@click" => "dismissOverviewDialog()")
.row .row
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment