Maintain commit order in MRs

`Gitlab::Git::Compare` will already have the correct order; sorting in Ruby can only ruin that. (The correct order being the same as `git log` - reverse chronological while maintaining the commit graph.) As an example, imagine a branch where someone has their system clock set wrong for some of the commits. Not only will those commits be in the wrong order - which is maybe reasonable - but sorting in Ruby can also put commits with the same timestamp out of order, as Ruby's sorting isn't stable.

Maintain commit order in MRs
27fdd3fe · Sean McGivern · 636b3ebb · 27fdd3fe
Commit 27fdd3fe authored May 18, 2016 by Sean McGivern
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

merge_request_diff.rb app/models/merge_request_diff.rb +1 -3

No files found.
--- a/app/models/merge_request_diff.rb
+++ b/app/models/merge_request_diff.rb
@@ -98,9 +98,7 @@ class MergeRequestDiff < ActiveRecord::Base
    commits = compare.commits
    if commits.present?
-      commits = Commit.decorate(commits, merge_request.source_project).
+      commits = Commit.decorate(commits, merge_request.source_project).reverse
-        sort_by(&:created_at).
-        reverse
    end
    commits