Don't pluck project IDs in User#owned_projects

This won't work efficiently if you happen to have a lot of projects.

Don't pluck project IDs in User#owned_projects
26482bdd · Yorick Peterse · 73f302ed · 26482bdd
Commit 26482bdd authored Nov 18, 2015 by Yorick Peterse
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

user.rb app/models/user.rb +2 -4

No files found.
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -404,10 +404,8 @@ class User < ActiveRecord::Base

  def owned_projects
    @owned_projects ||=
-      begin
-        namespace_ids = owned_groups.pluck(:id).push(namespace.id)
-        Project.in_namespace(namespace_ids).joins(:namespace)
-      end
+      Project.where('namespace_id IN (?) OR namespace_id = ?',
+                    owned_groups.select(:id), namespace.id).joins(:namespace)
  end

  # Team membership in authorized projects