BigW Consortium Gitlab

BE review changes

parent 6d2db33d
...@@ -63,7 +63,7 @@ class Blob < SimpleDelegator ...@@ -63,7 +63,7 @@ class Blob < SimpleDelegator
end end
def balsamiq? def balsamiq?
binary? && extname.downcase.delete('.') == 'bmpr' binary? && extension == 'bmpr'
end end
def stl? def stl?
......
...@@ -7,7 +7,6 @@ feature 'Balsamiq preview', :feature, :js do ...@@ -7,7 +7,6 @@ feature 'Balsamiq preview', :feature, :js do
let(:project) { create(:project) } let(:project) { create(:project) }
let(:branch) { 'add-balsamiq-file' } let(:branch) { 'add-balsamiq-file' }
let(:path) { 'files/images/balsamiq.bmpr' } let(:path) { 'files/images/balsamiq.bmpr' }
let(:file_content) { find('.file-content') }
before do before do
project.add_master(user) project.add_master(user)
...@@ -16,7 +15,7 @@ feature 'Balsamiq preview', :feature, :js do ...@@ -16,7 +15,7 @@ feature 'Balsamiq preview', :feature, :js do
end end
it 'should show a loading icon' do it 'should show a loading icon' do
expect(file_content).to have_selector('.loading') expect(find('.file-content')).to have_selector('.loading')
end end
it 'should show a viewer container' do it 'should show a viewer container' do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment